ASF GitHub Bot commented on ZOOKEEPER-2842:

Github user maoling commented on a diff in the pull request:

    --- Diff: 
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
    @@ -233,25 +233,25 @@ public QuorumCnxManager(QuorumPeer self) {
             listener = new Listener();
    --- End diff --
    I cannot help doing this although I know it will increase review work.I 
will keep it in my mind next time. **"When we say "do it separately" in the 
context of zk, it probably implies 'never'"** Quotation from hanm.

> optimize the finish() of Send/RecvWorker in QuorumCnxManager and remove 
> testInitiateConnection() and formates some codes
> ------------------------------------------------------------------------------------------------------------------------
>                 Key: ZOOKEEPER-2842
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2842
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: quorum
>            Reporter: maoling
>            Priority: Trivial
> 1.the finish() of Send/RecvWorker in QuorumCnxManager changes to 
> double-checked lock style 
> [https://en.wikipedia.org/wiki/Double-checked_locking]
> ,a trivial code changes implement a smaller granularity lock to have a better 
> perfermance in too fierce multithread situation.
> 2.testInitiateConnection() is redundant test function which is only used in 
> TestCase,so I refactor it.
> 3.some codes don't abide to Java Programme Specification ,so I lift a finger 
> to format them

This message was sent by Atlassian JIRA

Reply via email to