Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/308#discussion_r131591962
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -880,19 +876,20 @@ public void run() {
*
* @return boolean Value of variable running
*/
- synchronized boolean finish() {
- if(!running){
- /*
- * Avoids running finish() twice.
- */
- return running;
- }
- running = false;
-
- this.interrupt();
- threadCnt.decrementAndGet();
- return running;
- }
+ boolean finish() {
--- End diff --
Yes.we should keep a blance between optimization and readability.the most
importance thing for this optimization is whether this function has faced a
performace problem and this optimization is overdesign.
Haha.self-criticism.However ,I find the shadow of this programming paradigm in
zk code base
[Line501~Line507](https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/ClientCnxn.java
)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
