[
https://issues.apache.org/jira/browse/ZOOKEEPER-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118020#comment-16118020
]
ASF GitHub Bot commented on ZOOKEEPER-2826:
-------------------------------------------
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/298#discussion_r131847801
--- Diff: src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java ---
@@ -52,12 +52,12 @@
private String members;
/* version - version of config from which we want to reconfigure - if
current config is different
- * reconfiguration will fail. Should be ommitted from the CLI to
disable this option.
+ * reconfiguration will fail. Should be committed from the CLI to
disable this option.
--- End diff --
is it right?
> Code refactoring for `CLI` module
> ---------------------------------
>
> Key: ZOOKEEPER-2826
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2826
> Project: ZooKeeper
> Issue Type: Improvement
> Components: java client
> Affects Versions: 3.5.3
> Reporter: Benedict Jin
> Assignee: Benedict Jin
> Priority: Minor
> Fix For: 3.5.4, 3.6.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> * Fix spell issues
> * Remove unnecessary `import`
> * Make initialization block that related with `options.addOption` into static
> * Standardize `StringBuilder#append` usage
> * Using `try` clause to release the resource of stream
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
