Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/136#discussion_r132576447
  
    --- Diff: src/java/main/org/apache/zookeeper/ZooDefs.java ---
    @@ -74,12 +74,16 @@
     
             public final int createTTL = 21;
     
    +        public final int addPersistentWatch = 22;
    +
             public final int auth = 100;
     
             public final int setWatches = 101;
     
             public final int sasl = 102;
     
    +        public final int setWatches2 = 103;
    --- End diff --
    
    I don't think just because we are backporting this we need to keep this the 
same between the branches. I feel we should take advantage of the new version 
and keep the code as clean as possible. @hanm do you have an opinion on the 
matter?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to