[ https://issues.apache.org/jira/browse/ZOOKEEPER-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124808#comment-16124808 ]
ASF GitHub Bot commented on ZOOKEEPER-2859: ------------------------------------------- Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/319 The precommit job failured was fixed separately, and irrelevant to this patch. LGTM, merged to master: https://github.com/apache/zookeeper/commit/5bcffe9bc242d825ad97ff4f9d2dea6476983a9a 3.5: https://github.com/apache/zookeeper/commit/1bcf57dc775c5cec00f1f54414cf5a0e5f18e2f4 3.4: https://github.com/apache/zookeeper/commit/1f811a6281090e1b24152dc51507aa6a2bdeafe3 > CMake build doesn't support OS X > -------------------------------- > > Key: ZOOKEEPER-2859 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2859 > Project: ZooKeeper > Issue Type: Bug > Environment: OS X 10.12.6 > Reporter: Andrew Schwartzmeyer > Assignee: Andrew Schwartzmeyer > Fix For: 3.5.4, 3.6.0, 3.4.11 > > > Couple problems: > libm, librt, and libdl are all Linux specific, and provided "for free" on OS X > CppUnit (at least on OS X) needs `-std=c++11` > clang's ld doesn't understand --wrap > I can post an easy patch that at least lets you build the client (but not the > tests). The tests use that `--wrap` and it's non trivial to fix that on OS X. -- This message was sent by Atlassian JIRA (v6.4.14#64029)