[
https://issues.apache.org/jira/browse/ZOOKEEPER-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138131#comment-16138131
]
ASF GitHub Bot commented on ZOOKEEPER-2488:
-------------------------------------------
GitHub user bitgaoshu opened a pull request:
https://github.com/apache/zookeeper/pull/342
ZOOKEEPER-2488: Synchronized access to shuttingDownLE in QuorumPeer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bitgaoshu/zookeeper ZOOKEEPER-2488
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/342.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #342
----
commit 478ba42dbb41ca7895255e4661bfd081d84c88d1
Author: bitgaoshu <[email protected]>
Date: 2017-08-23T09:12:53Z
ZOOKEEPER-2488: Synchronized access to shuttingDownLE in QuorumPeer
----
> Unsynchronized access to shuttingDownLE in QuorumPeer
> -----------------------------------------------------
>
> Key: ZOOKEEPER-2488
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2488
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.5.2
> Reporter: Michael Han
> Fix For: 3.5.4, 3.6.0
>
>
> Access to shuttingDownLE in QuorumPeer is not synchronized here:
> https://github.com/apache/zookeeper/blob/3c37184e83a3e68b73544cebccf9388eea26f523/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java#L1066
> https://github.com/apache/zookeeper/blob/3c37184e83a3e68b73544cebccf9388eea26f523/src/java/main/org/
> The access should be synchronized as the same variable might be accessed
> in QuormPeer::restartLeaderElection, which is synchronized.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
