[
https://issues.apache.org/jira/browse/ZOOKEEPER-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142980#comment-16142980
]
Hadoop QA commented on ZOOKEEPER-2349:
--------------------------------------
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that
doesn't require tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/978//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/978//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/978//console
This message is automatically generated.
> Update documentation for snapCount
> ----------------------------------
>
> Key: ZOOKEEPER-2349
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2349
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
> Reporter: Raghavendra Prabhu
> Priority: Minor
> Attachments: ZOOKEEPER-2349.patch
>
>
> The documentation states that
> {code}
> ZooKeeper logs transactions to a transaction
> log. After snapCount transactions are written to a log
> file a snapshot is started and a new transaction log
> file is created. The default snapCount is
> 100,000.
> {code}
> However, in implementation, snapshotting is done when logCount is somwhere in
> (snapCount/2, snapCount+1], based on the limit set at runtime:
> {code}
> if (logCount > (snapCount / 2 + randRoll)) {
> {code}
> as in
> https://github.com/apache/zookeeper/blob/trunk/src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java#L124
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
