Github user arshadmohammad commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/338#discussion_r136144283
  
    --- Diff: conf/log4j.properties ---
    @@ -63,3 +63,20 @@ 
log4j.appender.TRACEFILE.File=${zookeeper.tracelog.dir}/${zookeeper.tracelog.fil
     log4j.appender.TRACEFILE.layout=org.apache.log4j.PatternLayout
     ### Notice we are including log4j's NDC here (%x)
     log4j.appender.TRACEFILE.layout.ConversionPattern=%d{ISO8601} 
[myid:%X{myid}] - %-5p [%t:%C{1}@%L][%x] - %m%n
    +#
    +# zk audit logging
    +#
    +zookeeper.auditlog.file=zookeeper_audit.log
    +zookeeper.auditlog.threshold=INFO
    +audit.logger=INFO, RFAAUDIT
    +log4j.logger.org.apache.zookeeper.audit.ZKAuditLogger=${audit.logger}
    +log4j.additivity.org.apache.zookeeper.audit.ZKAuditLogger=false
    +log4j.appender.RFAAUDIT=org.apache.log4j.RollingFileAppender
    --- End diff --
    
    It is very valid question. By RFAAUDIT i meant Rolling File Audit. Also one 
A is extra by mistake. I think it is better to change the name to AUDITFILE.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to