Github user bitgaoshu commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/356#discussion_r136739423
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -399,18 +403,20 @@ public boolean truncate(long zxid) throws IOException
{
}
long pos = input.getPosition();
// now, truncate at the current position
- RandomAccessFile raf=new RandomAccessFile(itr.logFile,"rw");
+ raf = new RandomAccessFile(itr.logFile, "rw");
raf.setLength(pos);
- raf.close();
while(itr.goToNextLog()) {
- if (!itr.logFile.delete()) {
- LOG.warn("Unable to truncate {}", itr.logFile);
+ try {
+ Files.delete(itr.logFile.toPath());
+ } catch (NoSuchFileException e) {
}
}
--- End diff --
- i think ```Files.delete``` can provide more detailed messages if delete
operation failed. I'm not sure this change is necessary or not.
- update
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
