Github user arshadmohammad commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/338#discussion_r136865979
--- Diff: src/java/main/org/apache/zookeeper/audit/AuditConstants.java ---
@@ -0,0 +1,37 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.zookeeper.audit;
+
+public class AuditConstants {
+ public static final String SUCCESS = "success";
+ public static final String FAILURE = "failure";
+ // operation is performed, result is not known yet
+ public static final String INVOKED = "invoked";
+ public static final String KEY_VAL_SEPARATOR = "=";
+ public static final char PAIR_SEPARATOR = '\t';
+
+ public static final String OP_START = "serverStart";
--- End diff --
- Operation names are something internal to ZooKeeper server. Shall we
expose this end user through API? I am not sure. I have tried to segregate
operation names though a different class. Please have a look.
- org.apache.zookeeper.ZooDefs.opNames is exposing operation names, this
operation name list is not complete. Also it has operation names which do not
exist like getMaxChildren and setMaxChildren. I have no idea why operation name
should be exposed and how it is used. Any idea on this ?
---
