[
https://issues.apache.org/jira/browse/ZOOKEEPER-2887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165155#comment-16165155
]
Hadoop QA commented on ZOOKEEPER-2887:
--------------------------------------
-1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that
doesn't require tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1027//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1027//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1027//console
This message is automatically generated.
> define dependency versions in build.xml to be easily overridden in
> build.properties
> -----------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2887
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2887
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Reporter: Tamas Penzes
> Assignee: Tamas Penzes
>
> Dependency versions are defined in ivy.xml, which is suboptimal since it is
> hard to override them from a script.
> If we defined the versions in the main build.xml (just as we do with
> audience-annotations.version) and use variables in ivy.xml then we could
> easily override the versions with creating a build.properties file, which
> mechanism is already built in.
> This way the dependency versions could be replaced by sed or any simple
> command line tool.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
