[
https://issues.apache.org/jira/browse/ZOOKEEPER-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175282#comment-16175282
]
Jordan Zimmerman edited comment on ZOOKEEPER-2901 at 9/21/17 6:55 PM:
----------------------------------------------------------------------
Update: I believe I have a mechanism to identify pre 3.5.4 files without
changing {{FileTxnLog.VERSION}}. Every file (snapshot and transaction) has a
header that maps to {{FileHeader.java}}. The field {{dbId}} isn't really used
for anything. For snapshots it's -1 and transactions it's 0. So, we can easily
use this. For post 3.5.3 files we can make dbId 1 for snapshots and 2 for
transactions (or whatever). When loading older files, we can invalidate any
sessions.
Question:
What is the best way to invalidate sessions when loading transactions and
snapshot files?
was (Author: randgalt):
Update: I believe I have a mechanism to identify pre 3.5.4 files without
changing `FileTxnLog.VERSION`. Every file (snapshot and transaction) has a
header that maps to `FileHeader.java`. The field `dbId` isn't really used for
anything. For snapshots it's -1 and transactions it's 0. So, we can easily use
this. For post 3.5.3 files we can make dbId 1 for snapshots and 2 for
transactions (or whatever). When loading older files, we can invalidate any
sessions.
Question:
What is the best way to invalidate sessions when loading transactions and
snapshot files?
> Session ID that is negative causes mis-calculation of Ephemeral Type
> --------------------------------------------------------------------
>
> Key: ZOOKEEPER-2901
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2901
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.5.3
> Environment: Running 3.5.3-beta in Docker container
> Reporter: Mark Johnson
> Assignee: Jordan Zimmerman
> Priority: Blocker
>
> In the code that determines the EphemeralType it is looking at the owner
> (which is the client ID or connection ID):
> EphemeralType.java:
> public static EphemeralType get(long ephemeralOwner) {
> if (ephemeralOwner == CONTAINER_EPHEMERAL_OWNER) {
> return CONTAINER;
> }
> if (ephemeralOwner < 0) {
> return TTL;
> }
> return (ephemeralOwner == 0) ? VOID : NORMAL;
> }
> However my connection ID is:
> header.getClientId(): -720548323429908480
> This causes the code to think this is a TTL Ephemeral node instead of a
> NORMAL Ephemeral node.
> This also explains why this is random - if my client ID is non-negative
> then the node gets added correctly.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
