[
https://issues.apache.org/jira/browse/ZOOKEEPER-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16195926#comment-16195926
]
ASF GitHub Bot commented on ZOOKEEPER-2630:
-------------------------------------------
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/395
This is a reasonable change and a good coding practice. That said it can be
a bit of a PITA if the active branches are not all addressed at the same time -
in makes it hard to do backports for example. Can you provide a patch that
applies to 3.4/3.5/trunk? Additionally ensure that no "public" interfaces are
changed. In particular ones that are exposed to external clients/coders.
> Use interface type instead of implementation type when appropriate.
> -------------------------------------------------------------------
>
> Key: ZOOKEEPER-2630
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2630
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Michael Han
> Assignee: Tamas Penzes
> Priority: Trivial
> Labels: newbie, refactoring
> Fix For: 3.6.0
>
>
> There are a couple of places in code base where we declare a field / variable
> as implementation type (i.e. HashMap, HashSet) instead of interface type
> (i.e. Map, Set), while in other places we do the opposite by declaring as
> interface type. A quick check indicates that most if not all of these places
> could be updated so we have a consistent style over the code base (prefer
> using interface type), which is also a good coding style to stick per best
> practice.
> See more info on https://github.com/apache/zookeeper/pull/102
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
