[
https://issues.apache.org/jira/browse/ZOOKEEPER-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199312#comment-16199312
]
Hadoop QA commented on ZOOKEEPER-2915:
--------------------------------------
-1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that
doesn't require tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1096//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1096//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1096//console
This message is automatically generated.
> Use "strict" conflict management in ivy
> ---------------------------------------
>
> Key: ZOOKEEPER-2915
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2915
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.5.4, 3.6.0, 3.4.11
> Reporter: Abraham Fine
> Assignee: Abraham Fine
>
> Currently it is very difficult to tell exactly which dependencies make it
> into the final classpath of zookeeper. We do not perform any conflict
> resolution between the test and default classpaths (this has resulted in
> strange behavior with the slf4j-log4j12 binding) and have no way of telling
> if a change to the dependencies has altered the transitive dependencies
> pulled down by the project.
> Our dependency list is relatively small so we should use "strict" conflict
> management (break the build when we try to pull two versions of the same
> dependency) so we can exercise maximum control over the classpath.
> Note: I also attempted to find a way to see if I could always prefer
> transitive dependencies from the default configuration over those pulled by
> the test configuration (to make sure that the zookeeper we test against has
> the same dependencies as the one we ship) but this appears to be impossible
> (or at least incredibly difficult) with ivy. Any opinions here would be
> greatly appreciated.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
