Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/412#discussion_r147803340
  
    --- Diff: 
src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java ---
    @@ -148,4 +152,20 @@ public static void serializeSnapshot(DataTree 
dt,OutputArchive oa,
             dt.serialize(oa, "tree");
         }
     
    +    public static byte[] serializeRequest(Request request) {
    +        if (request == null || request.getHdr() == null) return null;
    --- End diff --
    
    are there valid situations where this could return null?


---

Reply via email to