[ https://issues.apache.org/jira/browse/ZOOKEEPER-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238782#comment-16238782 ]
ASF GitHub Bot commented on ZOOKEEPER-2338: ------------------------------------------- Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/410 @fr0stbyte Reading some Stackoverflow about the flag (https://stackoverflow.com/questions/22304631/what-is-the-purpose-to-set-sock-cloexec-flag-with-accept4-same-as-o-cloexec), the change looks reasonable to me. However it would be beneficial to shed some light on how it's related to your scenario. > c bindings should create socket's with SOCK_CLOEXEC to avoid fd leaks on > fork/exec > ---------------------------------------------------------------------------------- > > Key: ZOOKEEPER-2338 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2338 > Project: ZooKeeper > Issue Type: Bug > Components: c client > Reporter: James DeFelice > Priority: Major > > I've observed socket FD leaks in Apache Mesos when using ZK to coordinate > master leadership: https://issues.apache.org/jira/browse/MESOS-4065 -- This message was sent by Atlassian JIRA (v6.4.14#64029)