Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/413#discussion_r149077678
  
    --- Diff: 
src/recipes/lock/test/org/apache/zookeeper/recipes/lock/ZNodeNameTest.java ---
    @@ -37,17 +37,30 @@ public void testOrderWithSamePrefix() throws Exception {
         @Test
         public void testOrderWithDifferentPrefixes() throws Exception {
             String[] names = { "r-3", "r-2", "r-1", "w-2", "w-1" };
    -        String[] expected = { "r-1", "r-2", "r-3", "w-1", "w-2" };
    +        // names with duplicated sequence numbers are not included in the 
result
    +        String[] expected = { "r-1", "r-2", "r-3" };
    --- End diff --
    
    Why have you removed "w-1" and "w-2" elements from here?
    I think the expected list could be:
    `String[] expected = { "r-1", "w-1", "r-2", "w-2", "r-3"};`


---

Reply via email to