Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/414#discussion_r149206744
  
    --- Diff: 
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
    @@ -255,30 +255,19 @@ private void padFile(FileOutputStream out) throws 
IOException {
          */
         public static File[] getLogFiles(File[] logDirList,long snapshotZxid) {
             List<File> files = Util.sortDataDir(logDirList, "log", true);
    --- End diff --
    
    couldn't we make the last param false and then we can use a simpler `for 
(File f : files)` loop?


---

Reply via email to