[ https://issues.apache.org/jira/browse/ZOOKEEPER-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245549#comment-16245549 ]
ASF GitHub Bot commented on ZOOKEEPER-2933: ------------------------------------------- Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/415#discussion_r149946468 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/LeaderStats.java --- @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.zookeeper.server.quorum; + +/** + * Provides live statistics about a running Leader. + */ +class LeaderStats { + /** + * Size of the last generated proposal. This should fit into server's jute.maxbuffer setting. + */ + private int lastProposalSize = 0; + + /** + * Size of the smallest proposal which has been generated since the server was started. + */ + private int minProposalSize = -1; + + /** + * Size of the largest proposal which has been generated since the server was started. + */ + private int maxProposalSize = 0; --- End diff -- Done. > Ability to monitor the jute.maxBuffer usage in real-time > -------------------------------------------------------- > > Key: ZOOKEEPER-2933 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2933 > Project: ZooKeeper > Issue Type: New Feature > Components: jute, server > Reporter: Andor Molnar > Assignee: Andor Molnar > Labels: buffer, buffer-length > Fix For: 3.5.4, 3.6.0 > > > This is related to jute.maxbuffer problems on the server side when Leader > generates a proposal that doesn't fit into Follower's Jute buffer causing the > quorum to be broken. > Proposed solution is to add the following new JMX Beans: > 1. Add getJuteMaxBuffer to ZookeeperServerBean which monitors the current > jute.maxbuffer setting, > 2. Add get last/min/max ProposalSize to LeaderBean which monitors the size of > the latest/min/max proposal. -- This message was sent by Atlassian JIRA (v6.4.14#64029)