[
https://issues.apache.org/jira/browse/ZOOKEEPER-2923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254349#comment-16254349
]
Hudson commented on ZOOKEEPER-2923:
-----------------------------------
FAILURE: Integrated in Jenkins build ZooKeeper-trunk #3610 (See
[https://builds.apache.org/job/ZooKeeper-trunk/3610/])
ZOOKEEPER-2923: The comment of the variable matchSyncs in class (phunt: rev
0fe7a09ab57c73c3a5c91e68a889f600c0739136)
* (edit) src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java
> The comment of the variable matchSyncs in class CommitProcessor has a mistake.
> ------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2923
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2923
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
> Affects Versions: 3.4.10, 3.5.3
> Reporter: Jiafu Jiang
> Assignee: Jiafu Jiang
> Priority: Minor
> Fix For: 3.5.4, 3.6.0, 3.4.12
>
>
> The comment of the variable matchSyncs in class CommitProcessor says:
> {code:java}
> /**
> * This flag indicates whether we need to wait for a response to come
> back from the
> * leader or we just let the sync operation flow through like a read. The
> flag will
> * be true if the CommitProcessor is in a Leader pipeline.
> */
> boolean matchSyncs;
> {code}
> I search the source code and find that matchSyncs will be false if the
> CommitProcessor is in a Leader pipeline, and it will be true if the
> CommitProcessor is in a Follower pipeline.
> Therefore I think the comment should be modified to match the code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
