Github user abel-von commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/423#discussion_r154279983
--- Diff: src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java ---
@@ -340,13 +340,24 @@ public static Packet getInstance() {
return instance;
}
}
+
/**
* ZKClientPipelineFactory is the netty pipeline factory for this netty
* connection implementation.
*/
private class ZKClientPipelineFactory implements
ChannelPipelineFactory {
private SSLContext sslContext = null;
private SSLEngine sslEngine = null;
+ private String host;
+ private int port;
+
+ public ZKClientPipelineFactory() {
--- End diff --
Maybe notï¼but it's just a good thing to keep the default constructor
when I define a constructor with parameters.
---
