[
https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16290237#comment-16290237
]
ASF GitHub Bot commented on ZOOKEEPER-2939:
-------------------------------------------
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/415
This seems like a reasonable addition (see below). I like the refactorings
(kudos). The code seems fine. I do have a couple questions though.
1) this information should also be added to mntr command output. The idea
of mntr is to have machine readable output - java properties format (we had
this prior to adding the jetty support).
2) the description for ZOOKEEPER-2939 is missing. I think it would be good
to give some insight into why you are proposing/submitting this change. Esp
around operational aspect.
3) it's not clear to me how useful this will be in practice, from an
operations perspective. Hopefully the answer to item 2 here will help. But say
you are running a cluster in production. It will be under some load, with new
proposals showing up pseudo-randomly, perhaps rapidly. last and min seem of
very little use (which perhaps is fine, similar to us capturing min latency).
Max I can see as useful. Why did you not decide to include "avg" for example?
Unfortunately our stats tracking was created before some of the metrics
tracking libraries available today were generally available. (might be a good
project for someone to investigate separately from this PR).
> Deal with maxbuffer as it relates to proposals
> ----------------------------------------------
>
> Key: ZOOKEEPER-2939
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: jute, server
> Reporter: Andor Molnar
> Assignee: Andor Molnar
> Fix For: 3.5.4, 3.6.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
