GitHub user anmolnar opened a pull request:
https://github.com/apache/zookeeper/pull/440
ZOOKEEPER-2939 Deal with maxbuffer as it relates to proposals - Use
dropwizard stats library
This PR is intended to be the successor of
https://github.com/apache/zookeeper/pull/415
Using dropwizard library's Histogram component we're able to provide more
sophisticated statistics on Proposal sizes.
From the docs:
"A histogram measures the statistical distribution of values in a stream of
data. In addition to minimum, maximum, mean, etc., it also measures median,
75th, 90th, 95th, 98th, 99th, and 99.9th percentiles."
http://metrics.dropwizard.io/3.1.0/manual/core/#histograms
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anmolnar/zookeeper ZOOKEEPER-2939-dropwizard
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/440.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #440
----
commit 6738e2d36b07f4643a97afd7e251a9d6c1c115f2
Author: Andor Molnár <andor@...>
Date: 2017-11-06T16:31:44Z
ZOOKEEPER-2939: Added last/min/max proposal size JMX beans
- Refactor proposal serialization logic to a common place,
- Add JMX metric to monitor jute.maxbuffer setting
- Add JMX metric to monitor min/max/last size of generated proposals
- This patch deals with server side maxbuffer monitoring only.
commit 68328d9027bf2a26d3425b9c83b4a9d5a526fc9b
Author: Andor Molnár <andor@...>
Date: 2017-12-01T11:59:48Z
ZOOKEEPER-2939. Fixed findbugs issue: newline in format string
commit ece8f09cb09c456ccb77903c9a2f6977c34c1543
Author: Andor Molnar <andor@...>
Date: 2017-12-15T18:11:17Z
ZOOKEEPER-2933. Added proposal size statistics to 'mntr' command
commit 89376898995ecb60e6f26252853fce1d6d85ba2b
Author: Andor Molnar <andor@...>
Date: 2017-12-18T16:34:24Z
ZOOKEEPER-2939. Added dropwizard library to calculate histogram of proposal
sizes
commit 70faba6c8f7478d44edf5fd22557df533bbbc6ce
Author: Andor Molnar <andor@...>
Date: 2018-01-02T15:24:12Z
ZOOKEEPER-2939. Fixed/added unit tests for Stat and Monitor commands
----
---
