[
https://issues.apache.org/jira/browse/ZOOKEEPER-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16309741#comment-16309741
]
ASF GitHub Bot commented on ZOOKEEPER-2960:
-------------------------------------------
GitHub user anmolnar opened a pull request:
https://github.com/apache/zookeeper/pull/441
ZOOKEEPER-2960. The dataDir and dataLogDir are used opposingly
Previously a small refactoring has swapped the usage of dataDir and
dataLogDir when QuorumPeerMain instantiates FileTxnSnapLog class.
This PR fixes it + adds unit test for verification.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anmolnar/zookeeper ZOOKEEPER-2960
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/441.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #441
----
commit 516147499541f7eb2b30f7a8cb4f50ed204469bb
Author: Andor Molnar <andor@...>
Date: 2018-01-03T14:47:26Z
ZOOKEEPER-2960. Fixed usage of dataDir and dataLogDir when instantiating
FileTxnSnapLog
----
> The dataDir and dataLogDir are used opposingly
> ----------------------------------------------
>
> Key: ZOOKEEPER-2960
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2960
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.4.11
> Environment: Not relevant.
> Reporter: Dan Milon
> Assignee: Andor Molnar
> Priority: Critical
>
> After upgrading from zookeeper 3.4.5, to 3.4.11, without editing {{zoo.cfg}},
> the new version of the server tries to use the {{dataDir}} as the
> {{dataLogDir}}, and the {{dataLogDir}} as the {{dataDir}}. Or at least some
> parts of the server.
> Configuration file has:
> {noformat}
> $ grep -i data /etc/zookeeper/zoo.cfg
> dataLogDir=/var/lib/zookeeper/datalog
> dataDir=/var/lib/zookeeper/data
> {noformat}
> But runtime configuration has:
> {noformat}
> $ echo conf | nc localhost 2181 | grep -i data
> dataDir=/var/lib/zookeeper/datalog/version-2
> dataLogDir=/var/lib/zookeeper/data/version-2
> {noformat}
> Also, I got this in the debug logs, so clearly some parts of the server
> confuse things.
> {noformat}
> [PurgeTask:FileTxnSnapLog@79] - Opening datadir:/var/lib/zookeeper/datalog
> snapDir:/var/lib/zookeeper/data
> [main:FileTxnSnapLog@79] - Opening datadir:/var/lib/zookeeper/data
> snapDir:/var/lib/zookeeper/datalog
> {noformat}
> I tried to look in the code for wrong uses of the directories. I only found
> [ZookeeperServer.java|https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java#L227]
> is passing the arguments to {{FileTxnSnapLog}} in the wrong order, but the
> code comment says that this is legacy only for tests, so I assume it isn't
> the cause for my case.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
