Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/439#discussion_r160244385
  
    --- Diff: src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java ---
    @@ -307,4 +315,104 @@ public void testReloadSnapshotWithMissingParent() 
throws Exception {
     
             startServer();
         }
    +
    +    /**
    +     * Verify that FileTxnIterator doesn't throw an EOFException when the
    +     * transaction log header is incomplete.
    +     */
    +    @Test
    +    public void testIncompleteHeader() throws Exception {
    +        ClientBase.setupTestEnv();
    +        File dataDir = ClientBase.createTmpDir();
    +        loadDatabase(dataDir, NUM_MESSAGES);
    --- End diff --
    
    Startup / shutdown logic should be in setUp() / tearDown() methods.


---

Reply via email to