Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/446#discussion_r162564621
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -1751,7 +1751,7 @@ public synchronized void initConfigInZKDatabase() {
if (zkDb != null) zkDb.initConfigInZKDatabase(getQuorumVerifier());
}
- public void setRunning(boolean running) {
+ private void setRunning(boolean running) {
--- End diff --
Sorry for the late answer. It's not too much of an insight, rather - in
general - I don't see the point of using a private setter without logic. In
other words, is there any objection against setting the field directly?
---
