[
https://issues.apache.org/jira/browse/ZOOKEEPER-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336426#comment-16336426
]
ASF GitHub Bot commented on ZOOKEEPER-2955:
-------------------------------------------
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/443#discussion_r163377320
--- Diff: build.xml ---
@@ -124,6 +160,7 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
<property name="ivy.javacc.lib" value="${build.dir}/javacc/lib"/>
<property name="ivy.releaseaudit.lib"
value="${build.dir}/releaseaudit/lib"/>
<property name="ivy.owasp.lib" value="${build.dir}/owasp/lib"/>
+ <property name="ivy.coverage.lib" value="${test.java.build.dir}/lib"/>
--- End diff --
My concern here is around classpath issues. Ideally I would like to make
sure that clover and its dependencies (my understanding is that there are none
currently but this could change) are only included when we are instrumenting
coverage. The given setup may see us including clover in the test classpath
even when not intended. For example, a developer wants to run the tests with
clover and then immediately after without. If my understanding is correct, it
there is no `clean` before those two executions clover will be included in the
classpath of the second.
> Enable Clover code coverage report
> ----------------------------------
>
> Key: ZOOKEEPER-2955
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2955
> Project: ZooKeeper
> Issue Type: Test
> Components: tests
> Affects Versions: 3.5.3, 3.4.11
> Reporter: Mark Fenes
> Assignee: Mark Fenes
> Priority: Major
>
> We have limited code coverage support in ZK. Clover for Java was running in
> the past but was turned off.
> Enable Clover code coverage report to make us more confident on the quality,
> stability and compatibility of future ZK releases.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
