Github user phunt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/377#discussion_r163712641
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -476,9 +474,12 @@ public ZooKeeperServerListener
getZooKeeperServerListener() {
return listener;
}
+ // Visible for testing
+ static volatile int serverId = 1;
--- End diff --
It being a global seems to kick the problem down the road to the next
person. I'm worried that setting this jvm wide could have an impact when
developing tests in the future. That's why it caught my eye.
---
