[
https://issues.apache.org/jira/browse/ZOOKEEPER-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364734#comment-16364734
]
ASF GitHub Bot commented on ZOOKEEPER-2967:
-------------------------------------------
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/459#discussion_r168301408
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileSnap.java ---
@@ -51,19 +51,22 @@
public class FileSnap implements SnapShot {
File snapDir;
private volatile boolean close = false;
- private static final int VERSION=2;
- private static final long dbId=-1;
+ private static final int VERSION = 2;
--- End diff --
Please revert this
> Add check to validate dataDir and dataLogDir parameters at startup
> ------------------------------------------------------------------
>
> Key: ZOOKEEPER-2967
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2967
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.11
> Reporter: Andor Molnar
> Assignee: Mark Fenes
> Priority: Major
> Labels: startup, validation
> Fix For: 3.5.4, 3.6.0, 3.4.12
>
>
> According to -ZOOKEEPER-2960- we should at a startup check to validate that
> dataDir and dataLogDir parameters are set correctly.
> Perhaps we should introduce a check of some kind? If datalogdir is different
> that datadir and snapshots exist in datalogdir we throw an exception and quit.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
