Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/451#discussion_r168572502 --- Diff: src/java/test/org/apache/zookeeper/test/ClientPortBindTest.java --- @@ -104,7 +104,7 @@ public void testBindByAddress() throws Exception { try { startSignal.await(CONNECTION_TIMEOUT, TimeUnit.MILLISECONDS); - Assert.assertTrue("count == 0", startSignal.getCount() == 0); + Assert.assertTrue("count == " + startSignal.getCount(), startSignal.getCount() == 0); --- End diff -- I'm not a huge fan of calling `getCount` more than once, since I think the value could change between invocations. Why not just use the return value from `await` in the line above?
---