[
https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366134#comment-16366134
]
ASF GitHub Bot commented on ZOOKEEPER-2184:
-------------------------------------------
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r168572502
--- Diff: src/java/test/org/apache/zookeeper/test/ClientPortBindTest.java
---
@@ -104,7 +104,7 @@ public void testBindByAddress() throws Exception {
try {
startSignal.await(CONNECTION_TIMEOUT,
TimeUnit.MILLISECONDS);
- Assert.assertTrue("count == 0", startSignal.getCount() == 0);
+ Assert.assertTrue("count == " + startSignal.getCount(),
startSignal.getCount() == 0);
--- End diff --
I'm not a huge fan of calling `getCount` more than once, since I think the
value could change between invocations. Why not just use the return value from
`await` in the line above?
> Zookeeper Client should re-resolve hosts when connection attempts fail
> ----------------------------------------------------------------------
>
> Key: ZOOKEEPER-2184
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2184
> Project: ZooKeeper
> Issue Type: Bug
> Components: java client
> Affects Versions: 3.4.6, 3.4.7, 3.4.8, 3.4.9, 3.4.10, 3.5.0, 3.5.1, 3.5.2,
> 3.5.3, 3.4.11
> Environment: Ubuntu 14.04 host, Docker containers for Zookeeper &
> Kafka
> Reporter: Robert P. Thille
> Assignee: Flavio Junqueira
> Priority: Blocker
> Labels: easyfix, patch
> Fix For: 3.5.4, 3.4.12
>
> Attachments: ZOOKEEPER-2184.patch
>
>
> Testing in a Docker environment with a single Kafka instance using a single
> Zookeeper instance. Restarting the Zookeeper container will cause it to
> receive a new IP address. Kafka will never be able to reconnect to Zookeeper
> and will hang indefinitely. Updating DNS or /etc/hosts with the new IP
> address will not help the client to reconnect as the
> zookeeper/client/StaticHostProvider resolves the connection string hosts at
> creation time and never re-resolves.
> A solution would be for the client to notice that connection attempts fail
> and attempt to re-resolve the hostnames in the connectString.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
