[
https://issues.apache.org/jira/browse/ZOOKEEPER-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376302#comment-16376302
]
ASF GitHub Bot commented on ZOOKEEPER-2936:
-------------------------------------------
GitHub user asutosh936 opened a pull request:
https://github.com/apache/zookeeper/pull/473
ZOOKEEPER-2936 - Removed duplicate code
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/asutosh936/zookeeper master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/473.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #473
----
commit a02ef3db8d18cc738a1a3e24eafcaa0b5379d297
Author: asutosh936 <asutosh.pandya@...>
Date: 2018-02-25T23:40:14Z
ZOOKEEPER-2936 - Removed duplicate code
----
> Duplicate Keys in log4j.properties config files
> -----------------------------------------------
>
> Key: ZOOKEEPER-2936
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2936
> Project: ZooKeeper
> Issue Type: Bug
> Components: contrib, other
> Affects Versions: 3.4.8
> Environment: Apache ZooKeeper source tarball
> Reporter: Hari Sekhon
> Priority: Trivial
>
> Recent versions of ZooKeeper have introduced the following duplicate keys in
> to the contrib log4j.properties files.
> In this file:
> {code}
> ./zookeeper-3.4.8/contrib/rest/conf/log4j.properties
> {code}
> and this file:
> {code}
> ./zookeeper-3.4.8/src/contrib/rest/conf/log4j.properties
> {code}
> the following duplicate keys are found:
> {code}
> log4j.appender.ROLLINGFILE.layout=org.apache.log4j.PatternLayout
> log4j.appender.ROLLINGFILE.layout.ConversionPattern=%d{ISO8601} - %-5p
> [%t:%C{1}@%L] - %m%n
> {code}
> This was discovered because I've written file validators for most major
> formats which recurse all my github repos and this was failing my integration
> tests when pulling ZooKeeper source code. I actually added --exclude and
> --ignore-duplicate-keys switches to {code}validate_ini.py{code} to work
> around this and fix my builds for now but just remembered to raise this to
> you guys.
> The validator tools if you're interested can be found at:
> https://github.com/harisekhon/pytools
> Cheers
> Hari
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
