[
https://issues.apache.org/jira/browse/ZOOKEEPER-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380932#comment-16380932
]
ASF GitHub Bot commented on ZOOKEEPER-2977:
-------------------------------------------
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/474
@sumitagrawl Thanks for opening this pull request and thanks for the
contribution.
This stuff with the test looks good to me.
Given that this is a fix in base class (ServerCnxn) rather than the NIO
implementation, have you considered adding similar test to Netty as well?
It might be even better to have a separate test file for the common code,
so we don't have to replicate tests every time we test something in here.
What do you think?
> Concurrency for addAuth corrupts quorum packets
> -----------------------------------------------
>
> Key: ZOOKEEPER-2977
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2977
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
> Affects Versions: 3.4.9
> Environment: Affects all version in 3.4.x
> Reporter: sumit agrawal
> Priority: Critical
> Fix For: 3.4.12
>
> Attachments: 2977.patch
>
>
> When client performs multiple times addAuth with different credential at
> follower concurrently, the communication between follower gets corrupt. This
> causes shutdown of Follower due to the failure.
> Analysis:
> In org.apache.zookeeper.server.quorum.QuorumPacket.serialize method,
> * call a_.startVector(authinfo,"authinfo"); which write the length of
> authinfo to packet (suppose it writes length 1)
> * get length of authinfo to write all details in loop (here gets length as 2)
> <-- Here in concurrency scenario, buffer gets corrupt having extra bytes in
> channel for additional authinfo.
>
> So When Leader reads next quorum packet, it reads previous extra bytes
> (incorrect) and possibly identify greater size of message (as corrupt byte
> pattern) causes exception...
> Coordination > Unexpected exception causing shutdown while sock still open
> (LearnerHandler.java:633)
> java.io.IOException: Unreasonable length = 1885430131
>
>
> ServerCnxn.getAuthInfo returns Unmodifiable list, but while addAuthInfo,
> there is no check. So this causes concurrency issue.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
