[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384214#comment-16384214
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2988:
-------------------------------------------

Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/476#discussion_r171972767
  
    --- Diff: 
src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java ---
    @@ -1064,7 +1065,12 @@ else if 
(self.getCurrentAndNextConfigVoters().contains(n.sid)) {
                             break;
                         }
                     } else {
    -                    LOG.warn("Ignoring notification from non-cluster 
member " + n.sid);
    +                    if 
(!self.getCurrentAndNextConfigVoters().contains(n.leader)) {
    +                        LOG.warn("Ignoring notification for non-cluster 
member sid {} from sid {}", n.leader, n.sid);
    +                    }
    +                    if 
(!self.getCurrentAndNextConfigVoters().contains(n.sid)) {
    +                        LOG.warn("Ignoring notification from non-cluster 
member sid {}", n.sid);
    --- End diff --
    
    nit: lets say "quorum" instead of "cluster"


> NPE triggered if server receives a vote for a server id not in their voting 
> view
> --------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2988
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2988
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: leaderElection
>    Affects Versions: 3.5.3, 3.4.11
>            Reporter: Brian Nixon
>            Priority: Minor
>
> We've observed the following behavior in elections when a node is lagging 
> behind the quorum in its view of the ensemble topology.
> - Node A is operating with node B in its voting view, but without view of 
> node C.
> - B votes for C.
> - A then switches its vote to C, but throws a NPE when attempting to connect.
> This causes the QuorumPeer to spin up a Follower only to immediately have it 
> shutdown by the exception.
> Ideally, A would not advertise a vote for a server that it will not follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to