Github user afine commented on the issue:

    https://github.com/apache/zookeeper/pull/488
  
    @asutosh936 I agree with @anmolnar That directory exists, it is currently 
in version control, and I don't think any generated files actually end up 
there. My guess is that it is there purely for historical reasons and to 
contain the rcc.jj file.
    
    In other words, I don't think your change to the gitignore will impact that 
directory. According to the gitignore documentation 
(https://git-scm.com/docs/gitignore):
    
    > If the pattern does not contain a slash /, Git treats it as a shell glob 
pattern and checks for a match against the pathname relative to the location of 
the .gitignore file (relative to the toplevel of the work tree if not from a 
.gitignore file).
    
    Since there are not any top level files called `generated` I don't think 
this line in the gitignore has any impact on the repository. Am I missing 
something here?
    



---

Reply via email to