[
https://issues.apache.org/jira/browse/ZOOKEEPER-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404599#comment-16404599
]
ASF GitHub Bot commented on ZOOKEEPER-3001:
-------------------------------------------
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/492#discussion_r175386273
--- Diff: src/java/main/org/apache/zookeeper/server/ContainerManager.java
---
@@ -116,8 +116,8 @@ public void checkContainers()
Request request = new Request(null, 0, 0,
ZooDefs.OpCode.deleteContainer, path, null);
try {
- LOG.info("Attempting to delete candidate container: %s",
- containerPath);
+ LOG.info(String.format("Attempting to delete candidate
container: %s",
--- End diff --
+1 for @eribeiro
We already use that form at various places in the codebase, so feel free to
use the better one. Existing String.formats should be refactored in the long
term, but that probably will happen in small refactorings like this.
> Incorrect log message when try to delete container node
> -------------------------------------------------------
>
> Key: ZOOKEEPER-3001
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3001
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.5.3
> Reporter: Sel-fish Finch
> Priority: Trivial
>
> The log message when trying to delete a container node is not proper, missing
> *_String.format_*
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
