Github user mfenes commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/490#discussion_r175393694
--- Diff: build.xml ---
@@ -475,23 +484,36 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
pattern="${ivy.lib}/[artifact]-[revision].[ext]"/>
<ivy:cachepath pathid="mvn-ant-task-classpath" conf="mvn-ant-task"/>
</target>
- <target name="compile" depends="ivy-retrieve,clover,build-generated">
- <javac srcdir="${java.src.dir}" destdir="${build.classes}"
includeantruntime="false"
+ <target name="compile"
depends="ivy-retrieve,clover,build-generated,ivy-retrieve-error_prone">
--- End diff --
Could we add the error prone compiler as an optional tool, so that
similarly to e.g. code coverage tools, the build could be run with or without
the tool?
---