lujie created ZOOKEEPER-3006:
--------------------------------
Summary: Potential NPE in ZKDatabase#calculateTxnLogSizeLimit
Key: ZOOKEEPER-3006
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3006
Project: ZooKeeper
Issue Type: Bug
Affects Versions: 3.6.0
Reporter: lujie
I have found a potential NPE in ZKDatabase#calculateTxnLogSizeLimit:
{code:java}
//ZKDatabase
public long calculateTxnLogSizeLimit() {
long snapSize = 0;
try {
snapSize = snapLog.findMostRecentSnapshot().length();
} catch (IOException e) {
LOG.error("Unable to get size of most recent snapshot");
}
return (long) (snapSize * snapshotSizeFactor);
}
{code}
in FileTxnSnapLog#findMostRecentSnapshot(), it will return the result of
FileSnap#findMostRecentSnapshot(FileSnap):
{code:java}
// called by FileTxnSnapLog#findMostRecentSnapshot()
public File findMostRecentSnapshot() throws IOException {
List<File> files = findNValidSnapshots(1);
if (files.size() == 0) {
return null;
}
return files.get(0);
}
{code}
So it will return null when the files sizes is 0, but
ZKDatabase#calculateTxnLogSizeLimit has no null checker
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
