[jira] [Commented] (ZOOKEEPER-2997) CMake should not force static CRT linking

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413285#comment-16413285
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2997:
-------------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/zookeeper/pull/485


> CMake should not force static CRT linking
> -----------------------------------------
>
>                 Key: ZOOKEEPER-2997
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2997
>             Project: ZooKeeper
>          Issue Type: Bug
>         Environment: Windows
>            Reporter: Andrew Schwartzmeyer
>            Assignee: Andrew Schwartzmeyer
>            Priority: Major
>             Fix For: 3.5.4, 3.6.0
>
>
> When writing the CMake build, I erroneously forced ZooKeeper to link to the 
> Windows CRT statically. Instead of setting this, we should rely on CMake's 
> defaults, and let users override it if they choose to by configuring with  
> setting {{CMAKE_CXX_ARGS}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)