[
https://issues.apache.org/jira/browse/ZOOKEEPER-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427958#comment-16427958
]
Hudson commented on ZOOKEEPER-3006:
-----------------------------------
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #3790 (See
[https://builds.apache.org/job/ZooKeeper-trunk/3790/])
ZOOKEEPER-3006: Potential NPE in ZKDatabase#calculateTxnLogSizeLimit (hanm: rev
fbd21329d32f185d198344f2d394175c92a82f9e)
* (edit) src/java/main/org/apache/zookeeper/server/ZKDatabase.java
* (edit) src/java/test/org/apache/zookeeper/test/ZkDatabaseCorruptionTest.java
> Potential NPE in ZKDatabase#calculateTxnLogSizeLimit
> ----------------------------------------------------
>
> Key: ZOOKEEPER-3006
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3006
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.6.0
> Reporter: lujie
> Assignee: Edward Ribeiro
> Priority: Major
> Fix For: 3.5.4, 3.6.0
>
>
> I have found a potential NPE in ZKDatabase#calculateTxnLogSizeLimit:
>
> {code:java}
> //ZKDatabase
> public long calculateTxnLogSizeLimit() {
> long snapSize = 0;
> try {
> snapSize = snapLog.findMostRecentSnapshot().length();
> } catch (IOException e) {
> LOG.error("Unable to get size of most recent snapshot");
> }
> return (long) (snapSize * snapshotSizeFactor);
> }
> {code}
> in FileTxnSnapLog#findMostRecentSnapshot(), it will return the result of
> FileSnap#findMostRecentSnapshot:
> {code:java}
> // called by FileTxnSnapLog#findMostRecentSnapshot()
> public File findMostRecentSnapshot() throws IOException {
> List<File> files = findNValidSnapshots(1);
> if (files.size() == 0) {
> return null;
> }
> return files.get(0);
> }
> {code}
> So it will return null when the files sizes is 0, but
> ZKDatabase#calculateTxnLogSizeLimit has no null checker
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
