Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/466#discussion_r181817033
--- Diff:
src/java/main/org/apache/zookeeper/server/command/MonitorCommand.java ---
@@ -75,9 +79,9 @@ public void commandRun() {
print("synced_followers",
leader.getForwardingFollowers().size());
print("pending_syncs", leader.getNumPendingSyncs());
- print("last_proposal_size",
leader.getProposalStats().getLastProposalSize());
- print("max_proposal_size",
leader.getProposalStats().getMaxProposalSize());
- print("min_proposal_size",
leader.getProposalStats().getMinProposalSize());
+ print("last_proposal_size",
leader.getProposalStats().getLast());
--- End diff --
Infact, getLastProposalSize, getMaxProposalSize, getMinProposalSize is more
meaningful. Can we keep this names?
---
