[
https://issues.apache.org/jira/browse/ZOOKEEPER-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449059#comment-16449059
]
ASF GitHub Bot commented on ZOOKEEPER-3000:
-------------------------------------------
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/490
This is a good addition, thanks for bringing to our attention @leventov .
Unfortunately however we can't replace the std javac compiler with
error_prone in the toolchain outright - we can have a separate option/target to
do this, but it can't be the default.
I would recommend separating this into two jiras/pullrequests - one to
change the build, the other to address the found issues.
@leventov you mentioned "I'm not proficient in Ant" - perhaps one of the
other folks could help with this? @anmolnar you mentioned hbase is using it -
anything we can pull from there wrt how they integrate it into their build?
ps. I like the idea of also getting this into 3.4 branch as well, which
means it needs to be optional so that the user can run it when they have
java8+, but otw not. Which matches my intent/statement above.
pps. looks like there is a new version of error_prone, might want to take
this opportunity to update the dependency version. I notice the library is
ASL2.0 which is also good (license is in the COPYING file currently)
> Use error-prone compiler
> ------------------------
>
> Key: ZOOKEEPER-3000
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3000
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.5.4, 3.6.0
> Reporter: Roman Leventov
> Assignee: Roman Leventov
> Priority: Major
> Fix For: 3.5.4, 3.6.0
>
>
> See http://errorprone.info/
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
