[
https://issues.apache.org/jira/browse/ZOOKEEPER-3027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456598#comment-16456598
]
Hadoop QA commented on ZOOKEEPER-3027:
--------------------------------------
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1645//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1645//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1645//console
This message is automatically generated.
> Accidently removed public API of FileTxnLog.setPreallocSize()
> -------------------------------------------------------------
>
> Key: ZOOKEEPER-3027
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3027
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.5.4, 3.6.0, 3.4.13
> Reporter: Andor Molnar
> Assignee: Andor Molnar
> Priority: Major
> Fix For: 3.5.4, 3.6.0, 3.4.13
>
>
> In my latest commit regarding TxnLogToolkit there's a refactor to outsource
> file padding logic from FileTxnLog to a separate class:
> [https://github.com/apache/zookeeper/commit/126fb0f22d701cad58bf3123bf7d8f2219e60387#diff-89717124564925d61d29dd817bcdd915]
> Unfortunately public static method setPreallocSize(int) has also been moved
> to the new class, but it's being actively used by hadoop-common project too:
> [https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/ClientBaseWithFixes.java#L384]
> I'd like to submit a patch to revert the deleted method which is going to
> call the new one, but will keep backward compatibility with Hadoop.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
