Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/520#discussion_r187663465
  
    --- Diff: build.xml ---
    @@ -23,6 +23,8 @@ xmlns:artifact="antlib:org.apache.maven.artifact.ant"
     xmlns:maven="antlib:org.apache.maven.artifact.ant"
     xmlns:cs="antlib:com.puppycrawl.tools.checkstyle">
     
    +    <property name="clover.version" value="4.2.1" />
    --- End diff --
    
    The "Dependency versions" section is around line 207 in build.xml. Would 
you please move the clover version there for consistency?
    
    You might also need to move the entire section here, because of some 
chicken-egg problem mentioned in the original patch.


---

Reply via email to