[
https://issues.apache.org/jira/browse/ZOOKEEPER-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475227#comment-16475227
]
Hadoop QA commented on ZOOKEEPER-3042:
--------------------------------------
-1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1693//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1693//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1693//console
This message is automatically generated.
> testFailedTxnAsPartOfQuorumLoss is flaky
> ----------------------------------------
>
> Key: ZOOKEEPER-3042
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3042
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
> Affects Versions: 3.5.3, 3.6.0, 3.4.12
> Reporter: Bogdan Kanivets
> Assignee: Bogdan Kanivets
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> According to the
> [dashboard|https://builds.apache.org/job/ZooKeeper-Find-Flaky-Tests/lastSuccessfulBuild/artifact/report.html]
> testFailedTxnAsPartOfQuorumLoss is flaky. I've looked at some logs and there
> are multiple causes of flakiness. One of them is in this line after step 5
> {code:java}
> Assert.assertEquals(1, outstanding.size());
> {code}
> For example
> [this|https://builds.apache.org/job/ZooKeeper_branch35_java10/10/artifact/build/test/logs]
> build of 3.5
> I was able to reproduce this particular issue in debug mode and the problem
> is that 'outstading' map can also have 'closeSession' entries that are
> expected.
> I'll submit a patch to relax this check.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
