Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/451#discussion_r190789369
--- Diff: src/java/main/org/apache/zookeeper/client/HostProvider.java ---
@@ -53,7 +54,7 @@
* @param spinDelay
* Milliseconds to wait if all hosts have been tried once.
*/
- public InetSocketAddress next(long spinDelay);
+ public InetSocketAddress next(long spinDelay) throws
UnknownHostException;
--- End diff --
Some questions here @anmolnar:
>> See my comment below. Now I think the API change is necessary, but I
need to double check how it was detected previously.
Which comment? I had a hard time find it, could you please explicitly paste
it here?
>> I started a thread on the mailing list a while ago for exactly the same
reason. Let me update it.
Similarly I lost that email thread. Could you please describe the gist of
the email?
I just wan to make sure we all agree that first an API change here is
needed and second, if the API changes we need throw the right type of
exception.
(Also note the current comment of HostProvider interface should be updated
if the API changes, because previous semantic of next always assume returns a
"valid" address.).
---
