Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r192158828
--- Diff:
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -348,20 +347,20 @@ public ChannelPipeline getPipeline() throws Exception
{
return p;
}
});
+ x509Util = new ClientX509Util();
}
private synchronized void initSSL(ChannelPipeline p)
throws X509Exception, KeyManagementException,
NoSuchAlgorithmException {
- String authProviderProp =
System.getProperty(ZKConfig.SSL_AUTHPROVIDER);
--- End diff --
Decent amount of code is used here to create SSLEngine for the pipeline.
Any objection against moving this to `ClientX509Util`?
---
