[GitHub] zookeeper pull request #534: ZOOKEEPER-2184 Zookeeper Client should re-resol...

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/534#discussion_r192694235
  
    --- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java 
---
    @@ -73,15 +80,27 @@
          *             if serverAddresses is empty or resolves to an empty list
          */
         public StaticHostProvider(Collection<InetSocketAddress> 
serverAddresses) {
    -       sourceOfRandomness = new Random(System.currentTimeMillis() ^ 
this.hashCode());
    +        init(serverAddresses,
    --- End diff --
    
    Sorry @lvfangmin , I might be missing the point here. Shall I change the 
signature to use non-generic Collection?


---