[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16513370#comment-16513370
 ] 

Michael Han commented on ZOOKEEPER-3063:
----------------------------------------

Good catch, committed to master and branch 3.5.

> Track outstanding changes with ArrayDeque
> -----------------------------------------
>
>                 Key: ZOOKEEPER-3063
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3063
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: Yisong Yue
>            Assignee: Yisong Yue
>            Priority: Trivial
>              Labels: pull-request-available
>             Fix For: 3.6.0, 3.5.5
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Outstanding changes are tracked with an ArrayList, which has O(N) remove from 
> head (and possibly add) performance. This means that as we get further 
> behind, we will slow down the processing of outstanding changes, which would 
> make us get further behind.
>  We should switch to using ArrayDeque which achieves O(1) add and remove on 
> both ends, which should result in much happiness.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to