[GitHub] zookeeper pull request #529: [ZOOKEEPER-2368] Send a watch event is when a c...

[enixon]

Github user enixon commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/529#discussion_r195949397
  
    --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java ---
    @@ -1438,6 +1436,11 @@ public void disconnect() {
             }
     
             sendThread.close();
    +        try {
    +            sendThread.join();
    +        } catch (InterruptedException ex) {
    +            LOG.warn("Got interrupted while waiting for the sender thread 
to close", ex);
    +        }
             eventThread.queueEventOfDeath();
    --- End diff --
    
    Any gains/problems with moving the queueEventOfDeath above the join()?


---